NEW(eslint): @W-17495039@: Allow users to specify other file extensions tha… #181
+148
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
force-pushed
the
sc/W-17495039
branch
4 times, most recently
from
48a8cbc to
bac0c0e
Compare
| files: this.config.file_extensions.javascript.map(ext => `*${ext}`), | ||
| extends: [`eslint:${baseRuleset}`] | ||
| } | ||
| return this.addJavascriptParser(jsConfig); |
There was a problem hiding this comment.
[Fix as you go item] I realized that the base config needed a parser while doing some addition testing on just the base rules. I just assumed that the default would just work out of the box. I never caught this before because the LWC rules were always pulling in the parser. So this only comes up when you disable the lwc rules but keep the base rules enabled.
jfeingold35
approved these changes
Dec 27, 2024
…t aren't associated with base plugins but only custom plugins
stephen-carter-at-sf
force-pushed
the
sc/W-17495039
branch
from
bac0c0e to
3e01253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t aren't associated with base plugins but only custom plugins